Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19984 )
Change subject: [util] clear OpenSSL error queue on jwt-cpp activity ...................................................................... [util] clear OpenSSL error queue on jwt-cpp activity As it turns out, jwt-cpp doesn't clean up OpenSSL error queue in case of errors. While I think it's a good idea to correct that improper OpenSSL API usage in the jwt-cpp library itself (and I'm going to work on a patch for jwt-cpp library upstream), I updated Kudu's jwt-util code to report on those errors and clean the error queue as an interim solution. I haven't added any tests, but a few tests in a follow-up patch would fail without these changes. This is a follow-up to 5a3d116f302bde07e86bf80c237f8a595d5003b4. Change-Id: I1a18a0d78bca0ea32878dc3825523e1bd6ecb019 Reviewed-on: http://gerrit.cloudera.org:8080/19895 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Wenzhe Zhou <[email protected]> Reviewed-by: Zoltan Chovan <[email protected]> Reviewed-by: Attila Bukor <[email protected]> (cherry picked from commit 1f00b0f42062629646d0e892436198893d89de36) Reviewed-on: http://gerrit.cloudera.org:8080/19984 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <[email protected]> --- M python/kudu/tests/test_client.py M src/kudu/util/jwt-util-test.cc M src/kudu/util/jwt-util.cc 3 files changed, 47 insertions(+), 48 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/19984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: merged Gerrit-Change-Id: I1a18a0d78bca0ea32878dc3825523e1bd6ecb019 Gerrit-Change-Number: 19984 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]>
