Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20017 )
Change subject: [wip][client] allow adding trusted CA certs for RPC connection negotiation ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/20017/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/20017/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@1183 PS3, Line 1183: securityContext.trustCertificates(certificates); I don't think this is going to work. The reason is that SecurityContext expects these certificates to be in DER format, while /ipki-ca-cert provides certificates in PEM format. http://gerrit.cloudera.org:8080/#/c/20017/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiation.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiation.java: http://gerrit.cloudera.org:8080/#/c/20017/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiation.java@72 PS3, Line 72: "--enable_client_jwt=true", I don't think there is such a master's flag. -- To view, visit http://gerrit.cloudera.org:8080/20017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I281fd59da0d24a6119b99e1da8096f381b414a2b Gerrit-Change-Number: 20017 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 07 Jun 2023 01:44:37 +0000 Gerrit-HasComments: Yes
