Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19622 )
Change subject: KUDU-3413 [multi-tenancy] add tenant info in metadata for multi-tenancy ...................................................................... Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/19622/12/src/kudu/fs/fs_manager-test.cc File src/kudu/fs/fs_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/19622/12/src/kudu/fs/fs_manager-test.cc@1213 PS12, Line 1213: if (!FLAGS_encrypt_data_at_rest && FLAGS_enable_multi_tenancy) { use GTEST_SKIP() instead? http://gerrit.cloudera.org:8080/#/c/19622/12/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/19622/12/src/kudu/fs/fs_manager.cc@656 PS12, Line 656: Fail to rewrite the instance metadata for path : $0, " : "rollback all the instance metadata file. How about: Fail to rewrite the instance metadata for path: $0, now try to rollback all the instance metadata file. http://gerrit.cloudera.org:8080/#/c/19622/12/src/kudu/fs/fs_manager.cc@684 PS12, Line 684: metadata->clear_format_stamp(); Is it necessary to clear it? The next line will write over it. http://gerrit.cloudera.org:8080/#/c/19622/12/src/kudu/fs/fs_manager.cc@832 PS12, Line 832: // If '--encrypt_data_at_rest' is not enabled or the tenant information is specified, : // we will not add the tenant information to the metadata, even the default tenant. The comment is a bit of confused. 1. it just explain the "tenant information", but the following codes are related both to "tenant information" and "server key" 2. the flag "--encrypt_data_at_rest" is far away to the real invoker (after line 894?) As all the if-else statements have their own comments, I suggest to remove this comment. -- To view, visit http://gerrit.cloudera.org:8080/19622 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e450d73940eb1dbaac6f905a46d6ccd084f15cf Gerrit-Change-Number: 19622 Gerrit-PatchSet: 12 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 08 Jun 2023 07:55:38 +0000 Gerrit-HasComments: Yes
