Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19518 )
Change subject: [Client] Add query id to trace the whole query process ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/19518/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19518/2//COMMIT_MSG@9 PS2, Line 9: This patch continues the work: https://gerrit.cloudera.org/c/18846 nit: This is a follow up patch of 834de7fccdb5faadb2ca9e1d1e07d4c7882ae0fa http://gerrit.cloudera.org:8080/#/c/19518/2//COMMIT_MSG@11 PS2, Line 11: Impala Not needed to mention Impala, Kudu Java client can be used for any Java applications. http://gerrit.cloudera.org:8080/#/c/19518/2/java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java File java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java: http://gerrit.cloudera.org:8080/#/c/19518/2/java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java@417 PS2, Line 417: nit: remove the space. http://gerrit.cloudera.org:8080/#/c/19518/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/19518/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@319 PS2, Line 319: ReplicaSelection replicaSelection, long keepAlivePeriodMs, String queryId) { Adding an additional parameter will break the API compatiblity, could you add another constructor instead? -- To view, visit http://gerrit.cloudera.org:8080/19518 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddbd348e766bad1b5648b4091635679319b1e2fd Gerrit-Change-Number: 19518 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 12 Jun 2023 09:08:01 +0000 Gerrit-HasComments: Yes
