Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20049 )
Change subject: KUDU-3475: Update to the most recent sse2neon.h ...................................................................... KUDU-3475: Update to the most recent sse2neon.h ARM builds on Ubuntu 20.04 hit an error about the redeclaration of vld1q_u8_x4 in sse2neon.h. This is because Ubuntu 20.04 uses GCC 9.4, which has its own definition of vld1q_u8_x4, and the preprocessor checks in the current sse2neon.h don't account for this correctly. Newer versions of sse2neon.h have namespaced their macros so that vld1q_u8_x4 is no longer used and improved the checks for GCC versions. This updates sse2neon.h to the latest available (commithash b7417bc). sse2neon.h has a large number of lint issues related to style (whitespace/braces, readability/casting) and none look like real correctness issues, so this exempts sse2neon.h from lint. Testing: - Built Kudu on Ubuntu 20.04 ARM64 and Ubuntu 18.04 ARM64 Change-Id: Id156a0b2c3984f9cb1032fa7747d7f9ed76c1f8c Reviewed-on: http://gerrit.cloudera.org:8080/19847 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <[email protected]> Reviewed-by: Yingchun Lai <[email protected]> (cherry picked from commit 7feb2cfc1e238ddaeb974aac24790fe36d920a48) Reviewed-on: http://gerrit.cloudera.org:8080/20049 Tested-by: Alexey Serbin <[email protected]> --- M build-support/lint.sh M src/kudu/util/sse2neon.h 2 files changed, 8,813 insertions(+), 3,028 deletions(-) Approvals: Alexey Serbin: Verified Yingchun Lai: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: merged Gerrit-Change-Id: Id156a0b2c3984f9cb1032fa7747d7f9ed76c1f8c Gerrit-Change-Number: 20049 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]>
