Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20051 )
Change subject: KUDU-3474: Add zlib as dependency of libunwind for ARM ...................................................................... KUDU-3474: Add zlib as dependency of libunwind for ARM On ARM, libunwind includes support for compressed .debug_info sections if zlib is available during compilation. This means that libunwind can require zlib at link time, but only for ARM architecture. This modifies the build to add a zlib dependency for libunwind if the architecture is ARM. It also reorders the thirdparty build so that zlib is built before libunwind. This is not strictly necessary, but it means that libunwind would consistently have support for compressed .debug_info sections on ARM. This does not impact x86_64. Testing: - Ran an ARM build on Ubuntu 20.04 Change-Id: Iee87b908a5771c2bd7c1a653504a1449d0792280 Reviewed-on: http://gerrit.cloudera.org:8080/19846 Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Alexey Serbin <[email protected]> (cherry picked from commit 96e648ac4a3d80a5d2194c834d82035fc90039e4) Reviewed-on: http://gerrit.cloudera.org:8080/20051 Reviewed-by: Yingchun Lai <[email protected]> --- M CMakeLists.txt M thirdparty/build-thirdparty.sh 2 files changed, 12 insertions(+), 5 deletions(-) Approvals: Alexey Serbin: Verified Yingchun Lai: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20051 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: merged Gerrit-Change-Id: Iee87b908a5771c2bd7c1a653504a1449d0792280 Gerrit-Change-Number: 20051 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]>
