Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19950 )
Change subject: [KUDU-3483] Log requestor info and request id for write interface ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/19950/2/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/19950/2/src/kudu/tserver/tablet_service.cc@1544 PS2, Line 1544: ptr ? > Deal with the case when request_id() is nullptr. When request_id() is nullptr, it will coredump. http://gerrit.cloudera.org:8080/#/c/19950/2/src/kudu/tserver/tablet_service.cc@1544 PS2, Line 1544: ontext->request_i > Is it necessary to use SecureDebugString on request_id()? request_id is a structure. It's type is rpc::RequestIdPB. -- To view, visit http://gerrit.cloudera.org:8080/19950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a3bacd947146fb52f94ab09dda94c96ed6d8ab8 Gerrit-Change-Number: 19950 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 15 Jun 2023 11:12:39 +0000 Gerrit-HasComments: Yes
