Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20083 )
Change subject: [client]KUDU-1945 Add upsert support ...................................................................... Patch Set 1: (2 comments) In client-test.cc there are tests which previously checked whether upsert/upsert_ignore is actually prohibited: InsertOperationNegatives. You could turn it into something like InsertOperationPositives. In the Python client, there were no tests implemented to check if upsert/upsert_ignore is implemented. I only added a TODO for it. Could you please remove these lines(to avoid confusion), and add it to this change: https://github.com/apache/kudu/blob/master/python/kudu/tests/test_client.py#L486-L488 http://gerrit.cloudera.org:8080/#/c/20083/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20083/1//COMMIT_MSG@7 PS1, Line 7: [client]KUDU-1945 nit: space [client] KUDU-1945 http://gerrit.cloudera.org:8080/#/c/20083/1/src/kudu/integration-tests/auto_incrementing-itest.cc File src/kudu/integration-tests/auto_incrementing-itest.cc: http://gerrit.cloudera.org:8080/#/c/20083/1/src/kudu/integration-tests/auto_incrementing-itest.cc@135 PS1, Line 135: "auto_incrementing_id" nit: Schema::GetAutoIncrementingColumnName() -- To view, visit http://gerrit.cloudera.org:8080/20083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27a95e3a6b1d1b584cad849978313b3c8222cd3d Gerrit-Change-Number: 20083 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 16 Jun 2023 15:21:38 +0000 Gerrit-HasComments: Yes
