Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20083 )
Change subject: [client] KUDU-1945 Add UPSERT support ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/20083/13/src/kudu/client/session-internal.cc File src/kudu/client/session-internal.cc: http://gerrit.cloudera.org:8080/#/c/20083/13/src/kudu/client/session-internal.cc@408 PS13, Line 408: case KuduWriteOperation::INSERT: : case KuduWriteOperation::INSERT_IGNORE: : RETURN_NOT_OK_ADD_ERROR(CheckAutoIncrementingColumnForInsert, op, error_collector_); : RETURN_NOT_OK_ADD_ERROR(CheckForNonNullableColumns, op, error_collector_); : break; : case KuduWriteOperation::UPSERT: : RETURN_NOT_OK_ADD_ERROR(CheckForNonNullableColumns, op, error_collector_); : case KuduWriteOperation::UPSERT_IGNORE: : case KuduWriteOperation::UPDATE: : case KuduWriteOperation::UPDATE_IGNORE: : RETURN_NOT_OK_ADD_ERROR(CheckAutoIncrementingColumnForNonInsert, op, error_collector_); : break; Maybe I'm missing something here, but according to my current understanding I would expect something like: INSERT and INSERT_IGNORE -> CheckAutoIncrementingColumnForInsert (to check that AI is not specified) UPSERT and UPSERT_IGNORE and UPDATE and UPDATE_IGNORE -> CheckAutoIncrementingColumnForNonInsert (to check that AI is specified) AI - auto-incrementing counter Could you please explain? -- To view, visit http://gerrit.cloudera.org:8080/20083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27a95e3a6b1d1b584cad849978313b3c8222cd3d Gerrit-Change-Number: 20083 Gerrit-PatchSet: 13 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Sun, 25 Jun 2023 07:35:19 +0000 Gerrit-HasComments: Yes
