Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/16887 )
Change subject: [java] allow disabling TLS transportation from java client ...................................................................... Patch Set 6: > Patch Set 5: Code-Review-1 > > This is a nice feature, but right now we don't use many environment > variables, especially on the client-side. I was also thinking about adding a > similar config to *require* TLS as right now it's trivial to MITM and > downgrade to clear text. If we used env vars, these two vars would collide. > > For these reasons, I'd rather we used code config which is a lot more robust > and I feel like it's more widespread in the Java world. Env vars can still be > added on the application-side if a user decides they want to control this > behavior by env vars, but it's also possible to read the config from an XML > or YAML config file as well if we opt to use code-configs. > > I realize this patch might not be the best place to discuss this, so maybe we > should bring this up on dev@ instead. In the meantime, I'd recommend against > merging this so I'm voting -1. I'll remove the variable environment and pass a clientBuilder variable to control whether rpc use TLS. -- To view, visit http://gerrit.cloudera.org:8080/16887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I762b9d6ef9257a7853684dd0aef315e5c5bba8ed Gerrit-Change-Number: 16887 Gerrit-PatchSet: 6 Gerrit-Owner: wangning <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Reviewer: wangning <[email protected]> Gerrit-Comment-Date: Fri, 30 Jun 2023 06:53:50 +0000 Gerrit-HasComments: No
