Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20016
to look at the new patch set (#2).
Change subject: logging.cc: Call GetLoggingDirectories before first write
......................................................................
logging.cc: Call GetLoggingDirectories before first write
Glog has a function called GetLoggingDirectories, which is explicitly not
thread-safe[1]. The comment promises it's not an issue since it is called
in InitGoogle, but it's not true right now, so it's called after
InitGoogleLogging as a workaround.
The workaround simply makes sure that GetLoggingDirectories in a single
thread so logging_directories_list will be initialized in a thread-safe
location.
1:
https://github.com/google/glog/blob/674283420118bb919f83ceb3d9dee31ef43ff3aa/src/logging.cc#L2325
Change-Id: I3e5cb73261015833c45ca5dd24e03bd1198b55ef
---
M src/kudu/util/logging.cc
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/20016/2
--
To view, visit http://gerrit.cloudera.org:8080/20016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3e5cb73261015833c45ca5dd24e03bd1198b55ef
Gerrit-Change-Number: 20016
Gerrit-PatchSet: 2
Gerrit-Owner: Ádám Bakai <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
