Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20185 )
Change subject: remove the supportng of EOL macOS 10.x ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/20185/1/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py File build-support/mini-cluster/relocate_binaries_for_mini_cluster.py: http://gerrit.cloudera.org:8080/#/c/20185/1/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py@101 PS1, Line 101: libc\+\+| I remember I tried this option. Indeed the process will succeed. However if I started Kudu afterwards and wanted to insert a row using kudu cli, it crashed. (Probably because libc++abi was not there). I was thinking that maybe we could do something like the sasl2 relocate. https://github.com/martongreber/kudu/blob/master/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py#L495-L501 keep this change, and adjust the link, and grab libc++abi from 3rdparty. This is just a wild guess. If I have time I will also look into this. http://gerrit.cloudera.org:8080/#/c/20185/1/docs/installation.adoc File docs/installation.adoc: http://gerrit.cloudera.org:8080/#/c/20185/1/docs/installation.adoc@63 PS1, Line 63: macOS 13 (Ventura) > I've built Kudu on macOS 13 (with Intel chip) successfully. Did you also run the build_mini_cluster_binaries.sh? With the current rev, it should run as well. But after the relocated binaries are there I got runtime crash after starting and inserting some rows. Could you please check this as well? -- To view, visit http://gerrit.cloudera.org:8080/20185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd0658eef8ee8b275e50d49f504c23de9615a5d7 Gerrit-Change-Number: 20185 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 11 Jul 2023 12:46:09 +0000 Gerrit-HasComments: Yes
