Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20067 )
Change subject: KUDU-3458 Startup tserver even if some metadata is corrupted ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/20067/4/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/20067/4/src/kudu/tserver/ts_tablet_manager.cc@949 PS4, Line 949: } : if (need_cleanup) { : CALLBACK_RETURN_NOT_OK( : Env::Default()->DeleteFile(fs_manager_->GetTabletMetadataPath(tablet_id))); : Env::Default()->DeleteFile(fs_manager_->GetConsensusMetadataPath(tablet_id)); : } > I'm not sure that's the right way to do this. At least, there is TabletMe Also, why is it necessary to remove those files at all here? I thought that the tablet copy client code would take care of that, but I might be missing something. -- To view, visit http://gerrit.cloudera.org:8080/20067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id44abaef5238b1de99350d8db43494a7120de608 Gerrit-Change-Number: 20067 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 12 Jul 2023 02:05:39 +0000 Gerrit-HasComments: Yes
