Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20185 )

Change subject: Remove the supporting of EOL macOS 10.x
......................................................................


Patch Set 2:

> Patch Set 2:
>
> > Patch Set 2:
> >
> > > Patch Set 1:
> > >
> > > > Patch Set 1: Code-Review+1
> > > >
> > > > I ran the build_mini_cluster_binaries.sh with this change successfully 
> > > > on macOS 13.4.1 (Apple M1 chip), and ran `kudu perf loadgen` to insert 
> > > > some rows to the cluster started with the built binaries.
> > >
> > > I guess if you could verify on M1 mac, I'm satisfied.
> > > I just tried again:
> > > mgreber@mgreber-MBP16 ~/Downloads/kudu-binary-1.18.0-SNAPSHOT-osx-arm64 $ 
> > > ./bin/kudu
> > > Killed: 9
> > >
> > > Did you use any special env variables?
> >
> > Well, I started kudu using the binaries in kudu/build/mini-cluster/bin 
> > before.
> >
> > When I tried to run binaries in 
> > kudu/build/mini-cluster/kudu-binary-1.18.0-SNAPSHOT-osx-arm64/bin it failed 
> > to start. I compared mini-cluster/bin/kudu and 
> > kudu-binary-1.18.0-SNAPSHOT-osx-arm64/bin/kudu and they are different.
>
> Yes I can confirm this.
> Running it from $KUDU_HOME/build/mini-cluster/bin works.
> However running what is in 
> $KUDU_HOME/build/mini-cluster/kudu-binary-1.18.0-SNAPSHOT-osx-arm64 is not 
> working. I get killed 9.

Have you checked the Console logs, I've ever encountered this issuse with the 
reason "Termination Reason:    Namespace CODESIGNING, Code 2", then I execute 
"find . -name "*" -execdir sudo codesign --force --deep --sign - {} \;" in the 
root of untared binary directory, then it works.

When publish the JARs, we will attach the signature by adding 
"-u='<APACHE-LDAP-USERNAME>' -p='<APACHE-LDAP-PASSWORD>'", then I guess it's 
not needed to sign mannually.


--
To view, visit http://gerrit.cloudera.org:8080/20185
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd0658eef8ee8b275e50d49f504c23de9615a5d7
Gerrit-Change-Number: 20185
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Yuqi Du <[email protected]>
Gerrit-Comment-Date: Sat, 15 Jul 2023 01:50:45 +0000
Gerrit-HasComments: No

Reply via email to