Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/20206 )
Change subject: [minidump] a minor cleanup on the minidump code
......................................................................
[minidump] a minor cleanup on the minidump code
I looked through the code of the minidump wrapper in the context of
KUDU-3491 and cleaned up the related sections a bit:
* explicitly initialize the 'user_signal_handler_thread_running_' field
* changed the signature of the minidump_dir() method to return
'const std::string' and perform an extra sanity check (debug-only)
* changed the type from 'int' to 'size_t' and explicitly initialize
the 'current_num_instances_' static member: that's not necessary per
the C++ standard (at least C++17), but might help to work around
possible compiler bugs
* other minor updates: code style, etc.
Change-Id: I33b0c528975bf50a6fe16b9c2f76eeb685e5dd35
Reviewed-on: http://gerrit.cloudera.org:8080/20206
Reviewed-by: Abhishek Chennaka <achenn...@cloudera.com>
Tested-by: Alexey Serbin <ale...@apache.org>
---
M src/kudu/util/minidump.cc
M src/kudu/util/minidump.h
2 files changed, 31 insertions(+), 20 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/20206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I33b0c528975bf50a6fe16b9c2f76eeb685e5dd35
Gerrit-Change-Number: 20206
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <ale...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <ale...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Ádám Bakai <aba...@cloudera.com>
