Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20188 )
Change subject: KUDU-3402 Update trace-viewer with newest catapult changes. ...................................................................... Patch Set 7: Code-Review+1 > (1 comment) > > > I checked out the new tracing.html on macOS with up to date > Chrome! > > Overall it looks really good. The functionality is there, things > > are working as expected previously. Nice! > > > > There is one caveat: once we do a recording, now on the right we > > see a toolbar on the right with items: File Size Stats, Metrics, > > Frame Data, Input Latency, Alerts. These seem more Chromium > > specific, we don't really get value from them, and in the > previous > > version it wasn't present. Is there a way to remove this right > > toolbar? > > > > Moreover on the top bar, there is a button called View Options > [-> > > Highlight VSync], which was present in the previous version. > > However this one does not provide additional value neither. Could > > this one be removed somehow? > > I removed the side panel and the view options. > https://github.com/cloudera/catapult/commit/99efe2f56191867ba7bb602c7c227dea6d576d2f > (1 comment) > > > I checked out the new tracing.html on macOS with up to date > Chrome! > > Overall it looks really good. The functionality is there, things > > are working as expected previously. Nice! > > > > There is one caveat: once we do a recording, now on the right we > > see a toolbar on the right with items: File Size Stats, Metrics, > > Frame Data, Input Latency, Alerts. These seem more Chromium > > specific, we don't really get value from them, and in the > previous > > version it wasn't present. Is there a way to remove this right > > toolbar? > > > > Moreover on the top bar, there is a button called View Options > [-> > > Highlight VSync], which was present in the previous version. > > However this one does not provide additional value neither. Could > > this one be removed somehow? > > I removed the side panel and the view options. > https://github.com/cloudera/catapult/commit/99efe2f56191867ba7bb602c7c227dea6d576d2f Thanks for taking care of this! Looks good to me! -- To view, visit http://gerrit.cloudera.org:8080/20188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I931de59a2cad944bfb945b3e1bee3e9c96b5b34b Gerrit-Change-Number: 20188 Gerrit-PatchSet: 7 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 19 Jul 2023 16:46:11 +0000 Gerrit-HasComments: No
