Hello Marton Greber, Alexey Serbin, Kudu Jenkins, I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/20228 to review the following change. Change subject: [client] KUDU-1945 Add UPSERT support ...................................................................... [client] KUDU-1945 Add UPSERT support This patch adds UPSERT support to Kudu C++ and Java clients by removing the previously added checks to discard UPSERT operations. The functionality added is only supported if the entire primary key is provided including the auto-incrementing column. Also added verification to reject INSERT operations with auto-incrementing column set on the client side. Thanks to Marton Greber for diagnosing the python client side issue. Change-Id: I27a95e3a6b1d1b584cad849978313b3c8222cd3d Reviewed-on: http://gerrit.cloudera.org:8080/20083 Tested-by: Kudu Jenkins Reviewed-by: Marton Greber <greber...@gmail.com> Reviewed-by: Alexey Serbin <ale...@apache.org> (cherry picked from commit 39302dfa8edc1fd1268f78f3ddd3f34ca26cc43f) --- M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java M python/kudu/tests/test_client.py M src/kudu/client/client-test.cc M src/kudu/client/session-internal.cc M src/kudu/common/partial_row.cc M src/kudu/common/partial_row.h M src/kudu/integration-tests/auto_incrementing-itest.cc 9 files changed, 318 insertions(+), 92 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/20228/1 -- To view, visit http://gerrit.cloudera.org:8080/20228 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: newchange Gerrit-Change-Id: I27a95e3a6b1d1b584cad849978313b3c8222cd3d Gerrit-Change-Number: 20228 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com>