Hello Kudu Jenkins, Abhishek Chennaka, Ádám Bakai,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20262
to look at the new patch set (#3).
Change subject: WIP [fs] improve rolling back of the initial FS layout
......................................................................
WIP [fs] improve rolling back of the initial FS layout
This patch allows for less manual intervention when adding an extra Kudu
master into a cluster fails because of an error during creation of the
initial FS layout. The rollback logic is engaging only on first run,
when no existing FS layout is present yet.
As for testing, the already existing TestSomeMastersUnreachable scenario
of the AutoAddMasterTest has been updated correspondingly.
WIP:
* collect initial feedback
* clean up the code a bit
* maybe, add more tests to cover various failure modes
* make sure the logic isn't engaging on already existing FS,
e.g. when there is some corruption on existing file or so
Change-Id: I92821416ca44cde79524b08b49f642dd59102f62
---
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/dir_manager.cc
M src/kudu/fs/dir_manager.h
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
M src/kudu/master/dynamic_multi_master-test.cc
M src/kudu/master/master.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/server/server_base.cc
M src/kudu/server/server_base.h
10 files changed, 173 insertions(+), 70 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/20262/3
--
To view, visit http://gerrit.cloudera.org:8080/20262
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I92821416ca44cde79524b08b49f642dd59102f62
Gerrit-Change-Number: 20262
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Ádám Bakai <[email protected]>