Marton Greber has posted comments on this change. (
http://gerrit.cloudera.org:8080/19882 )
Change subject: PROTOTYPE: Port of IMPALA-11694 over to Kudu gutils
......................................................................
Patch Set 2:
The current patchset fails on ARM OSX:
In file included from ../../src/kudu/util/metrics.h:253:
../../src/kudu/util/atomic.h:210:7: error: no matching function for call to
'Release_Store'
base::subtle::Release_Store(&value_, new_value);
^~~~~~~~~~~~~~~~~~~~~~~~~~~
../../src/kudu/gutil/atomicops-internals-portable.h:129:13: note: candidate
function not viable: no known conversion from 'kudu::AtomicInt<long
long>::SignedT *' (aka 'long long *') to 'volatile base::subtle::Atomic32 *'
(aka 'volatile int *') for 1st argument
inline void Release_Store(volatile Atomic32* ptr, Atomic32 value) {
^
../../src/kudu/gutil/atomicops-internals-portable.h:229:13: note: candidate
function not viable: no known conversion from 'kudu::AtomicInt<long
long>::SignedT *' (aka 'long long *') to 'volatile base::subtle::Atomic64 *'
(aka 'volatile long *') for 1st argument
inline void Release_Store(volatile Atomic64* ptr, Atomic64 value) {
^
4 warnings and 12 errors generated.
What seems to be the 'regression':
Previously in atomicops-internals-macosx.h we had:
typedef int64_t Atomic64;
However with the latest changes we have:
typedef intptr_t Atomic64;
where intptr_t results in long.
By using int64_t instead of intptr_t, everything seems to work. Would this be
acceptable? (on the other hand I'm not sure how this works in Chromium)
--
To view, visit http://gerrit.cloudera.org:8080/19882
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie490b9b3aa7159a1642c07b6b7e642dfac2de55e
Gerrit-Change-Number: 19882
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Comment-Date: Thu, 27 Jul 2023 15:47:00 +0000
Gerrit-HasComments: No
