Marton Greber has posted comments on this change. (
http://gerrit.cloudera.org:8080/19938 )
Change subject: KUDU-3477 Function to get flags of minicluster daemons.
......................................................................
Patch Set 6:
> Patch Set 6:
>
> (3 comments)
Regarding the functionality it looks good to me!
Small addition:
- could you please add the corresponding Java side implementation for
'getMasterFlags' and 'setMasterFlags' in MiniKuduCluster.java?
- Add some tests in TestMiniKuduCluster.java (both for getting master and
tserver flags):
* check that we get non-zero number of flags,
* check that a given default flag is present in the flag list,
* set a test specific flag, and check that we get it back.
(test specific flags are set like:
@MasterServerConfig(flags = {
"--master_client_location_assignment_enabled=true",
})
public void testClientLocation() throws Exception {
)
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/19938
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3480bfccce18c4605ed9b4ed1dab367fa1fd525a
Gerrit-Change-Number: 19938
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Martonka <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Wang Xixu <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Comment-Date: Thu, 27 Jul 2023 21:25:09 +0000
Gerrit-HasComments: No
