Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18441 )
Change subject: [tserver] KUDU-1827: tserver decommission ...................................................................... Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/18441/12/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/18441/12/src/kudu/master/auto_rebalancer-test.cc@285 PS12, Line 285: Status ChangeTServerState(const string& uuid, TServerStateChangePB::StateChange change) { If I don't miss something, what is this method used for? http://gerrit.cloudera.org:8080/#/c/18441/12/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18441/12/src/kudu/tools/kudu-tool-test.cc@8400 PS12, Line 8400: } Maybe we also need to check there is no replica on the decommissioned tablet server. http://gerrit.cloudera.org:8080/#/c/18441/12/src/kudu/tools/tool_action_tserver.cc File src/kudu/tools/tool_action_tserver.cc: http://gerrit.cloudera.org:8080/#/c/18441/12/src/kudu/tools/tool_action_tserver.cc@460 PS12, Line 460: RETURN_NOT_OK(IsDecommissioningInProgress(context, &decommissioningInProgress)); : : if (decommissioningInProgress) { : return Status::IllegalState("Decommissioning already in progress"); : } : If `decommissioningInProgress` is true, the method will return a non-OK status, right? http://gerrit.cloudera.org:8080/#/c/18441/12/src/kudu/tools/tool_action_tserver.cc@495 PS12, Line 495: /* max_moves_per_server = */ 5, : /* max_staleness_interval_sec = */ 300, : /* max_run_time_sec = */ 0, Can these parameters also be configurable? -- To view, visit http://gerrit.cloudera.org:8080/18441 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15c52b653c20b2a3a45fbf8934f19f6bd1a9caea Gerrit-Change-Number: 18441 Gerrit-PatchSet: 12 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 31 Jul 2023 15:01:07 +0000 Gerrit-HasComments: Yes
