Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20283 )
Change subject: [cmake] clean up on targets when using NO_TESTS=1 ...................................................................... [cmake] clean up on targets when using NO_TESTS=1 This patch updates makefiles to remove unnecessary targets when the build is configured using 'cmake -DNO_TESTS=1 ...'. It reduces CPU and disk consumption when building with NO_TESTS=1. Also, the sanitizer_options static library is now built only in ASAN/TSAN configurations. This patch doesn't add any functional changes in the Kudu's code itself, except that the kudu CLI tool no longer offer the 'kudu test' action when built with NO_TESTS=1. That also made the size of the kudu CLI binary a bit smaller. If comparing the sizes of the stripped binaries, I got the following numbers when building on CentOS7.9 with NO_TESTS=1 in RELEASE configuration using devtoolset-8: before: 67883424 bytes after: 66891680 bytes Change-Id: I6de4f9498bef9b2102ea6507a35ad78b08d4c27a Reviewed-on: http://gerrit.cloudera.org:8080/20281 Tested-by: Kudu Jenkins Reviewed-by: Yifan Zhang <[email protected]> Reviewed-by: Yingchun Lai <[email protected]> (cherry picked from commit 7f9b74ff665d3593e005e31a50d0029f4f2e2619) Reviewed-on: http://gerrit.cloudera.org:8080/20283 Tested-by: Yingchun Lai <[email protected]> --- M CMakeLists.txt M src/kudu/benchmarks/CMakeLists.txt M src/kudu/cfile/CMakeLists.txt M src/kudu/client/CMakeLists.txt M src/kudu/clock/CMakeLists.txt M src/kudu/common/CMakeLists.txt M src/kudu/consensus/CMakeLists.txt M src/kudu/fs/CMakeLists.txt M src/kudu/gutil/CMakeLists.txt M src/kudu/hms/CMakeLists.txt M src/kudu/master/CMakeLists.txt M src/kudu/mini-cluster/CMakeLists.txt M src/kudu/postgres/CMakeLists.txt M src/kudu/ranger-kms/CMakeLists.txt M src/kudu/ranger/CMakeLists.txt M src/kudu/rebalance/CMakeLists.txt M src/kudu/rpc/CMakeLists.txt M src/kudu/security/CMakeLists.txt M src/kudu/server/CMakeLists.txt M src/kudu/subprocess/CMakeLists.txt M src/kudu/tablet/CMakeLists.txt M src/kudu/tools/CMakeLists.txt M src/kudu/tools/tool_action.h M src/kudu/tools/tool_action_test.cc M src/kudu/tools/tool_main.cc M src/kudu/transactions/CMakeLists.txt M src/kudu/tserver/CMakeLists.txt M src/kudu/util/CMakeLists.txt 28 files changed, 381 insertions(+), 264 deletions(-) Approvals: Yingchun Lai: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/20283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: merged Gerrit-Change-Id: I6de4f9498bef9b2102ea6507a35ad78b08d4c27a Gerrit-Change-Number: 20283 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]>
