Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20313 )
Change subject: [test_util] more accurate status codes for WaitForBind() ...................................................................... [test_util] more accurate status codes for WaitForBind() When troubleshooting failed test scenarios involving the mini_ranger and the mini_ranger_kms test wrappers, I found it's hard to decipher error messages when the underlying memory hogs were slow to start within the specified timeout of 90 seconds. This patch addresses the issue, so in case of timeout the WaitForBind() utility returns Status::TimedOut() with comprehensive error message. I also took the liberty of making the timeout tracking more precise and fixing minor code style issues in the related code. Change-Id: Ic4ed06540d3f4d86bb61f96ffb36ffc671e1c485 Reviewed-on: http://gerrit.cloudera.org:8080/20313 Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Alexey Serbin <[email protected]> --- M src/kudu/ranger-kms/mini_ranger_kms.cc M src/kudu/ranger/mini_ranger.cc M src/kudu/util/test_util.cc 3 files changed, 30 insertions(+), 18 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/20313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic4ed06540d3f4d86bb61f96ffb36ffc671e1c485 Gerrit-Change-Number: 20313 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
