Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20310 )
Change subject: KUDU-3497 optimize leader rebalancer algorithm ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/20310/2/src/kudu/master/auto_leader_rebalancer.cc File src/kudu/master/auto_leader_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/20310/2/src/kudu/master/auto_leader_rebalancer.cc@209 PS2, Line 209: if (!tablet_ids_ptr) { > nit: is it possible to use this criterion as-is in the condition for the 'i It was copied from below~, done. http://gerrit.cloudera.org:8080/#/c/20310/2/src/kudu/master/auto_leader_rebalancer.cc@228 PS2, Line 228: f all the remain > is divisible Done http://gerrit.cloudera.org:8080/#/c/20310/2/src/kudu/master/auto_leader_rebalancer.cc@228 PS2, Line 228: vers, the lea > the number of remaining Done http://gerrit.cloudera.org:8080/#/c/20310/2/src/kudu/master/auto_leader_rebalancer.cc@228 PS2, Line 228: er num > tablet replicas The value is tablet indeed. http://gerrit.cloudera.org:8080/#/c/20310/2/src/kudu/master/auto_leader_rebalancer.cc@228 PS2, Line 228: tablet server > the number of remaining Done -- To view, visit http://gerrit.cloudera.org:8080/20310 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f1fe796fd98da2d8764da793b7e254319e6348a Gerrit-Change-Number: 20310 Gerrit-PatchSet: 3 Gerrit-Owner: Song Jiacheng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Song Jiacheng <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 08 Aug 2023 10:07:34 +0000 Gerrit-HasComments: Yes
