Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20347 )
Change subject: KUDU-3503 Allow extra JVM arguments ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/20347/2/src/kudu/ranger/ranger_client-test.cc File src/kudu/ranger/ranger_client-test.cc: http://gerrit.cloudera.org:8080/#/c/20347/2/src/kudu/ranger/ranger_client-test.cc@389 PS2, Line 389: > Do you think it's worth adding a scenario with passing unknown options to t Yea that's a good point. Added it. http://gerrit.cloudera.org:8080/#/c/20347/2/src/kudu/ranger/ranger_client-test.cc@398 PS2, Line 398: > nit: would it make sense to rather rely on successful authorization instead Makes sense, changed it. http://gerrit.cloudera.org:8080/#/c/20347/2/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/20347/2/src/kudu/ranger/ranger_client.cc@369 PS2, Line 369: for (auto& arg : args) { : ret.emplace_back(std::move(arg)); : } > nit: could use 'auto& arg' and do std::move() each element from the 'args' Done -- To view, visit http://gerrit.cloudera.org:8080/20347 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60f82e8a2fe106b267da3d2acd71a61e5a46a759 Gerrit-Change-Number: 20347 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 15 Aug 2023 15:06:59 +0000 Gerrit-HasComments: Yes
