Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20346 )
Change subject: KUDU-3359 Allow multi-JAR cp for Ranger client ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/20346/1/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/20346/1/src/kudu/ranger/ranger_client.cc@251 PS1, Line 251: if (std::any_of(kLevels.begin(), kLevels.end(), : [&vlower] (const string& level) { return level == vlower; })) { : return true; : } > Not sure if it's worth doing, Java will log non-existent paths IIRC, but if Ah, if the JVM can start with whatever it's given with all those flags and log about the paths that are non-existent, I guess that's fine then. -- To view, visit http://gerrit.cloudera.org:8080/20346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If137b5541b948506372db50e984eeee7e05dfd22 Gerrit-Change-Number: 20346 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 18 Aug 2023 00:54:15 +0000 Gerrit-HasComments: Yes
