Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20314 )

Change subject: KUDU-3432: Fix flakiness in client-test.cc
......................................................................


Patch Set 2: Code-Review+2

OK, this is possible to check this test scenario for stability even without 
using dist-test.  I used the following

./bin/client-test --gtest_filter=TableKeyRangeTest.TestGetTableKeyRange 
--gtest_repeat=100 --stress_cpu_threads=8

Prior to PS2, I could see the following errors (maybe, one in 50 runs when 
running the bits compiled in RELEASE configuration):

src/kudu/client/client-test.cc:8788: Failure
Expected: (4) < (token_size_a), actual: 4 vs

With PS2, I ran it a few hundred times and didn't see a single failure.

Thank you for the fix!


--
To view, visit http://gerrit.cloudera.org:8080/20314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e3fecc09f58d91fe9a8c6d20caa21938dd9c972
Gerrit-Change-Number: 20314
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: KeDeng <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Tue, 22 Aug 2023 01:31:23 +0000
Gerrit-HasComments: No

Reply via email to