Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 )
Change subject: WIP KUDU-3371 [fs] Use RocksDB to store LBM metadata ...................................................................... Patch Set 47: (1 comment) http://gerrit.cloudera.org:8080/#/c/18569/47//COMMIT_MSG Commit Message: PS47: Before posting many comments on the code of this patch itself, I think it's important to rule out one major point first. I looked at this patch briefly in the past, posting some feedback, but it seems I was missing one major issue with RocksDB: its dual GPLv2 and Apache 2.0 license that the RocksDB comes with: https://github.com/facebook/rocksdb/#license. Even if the project's license states that one _may_ select one of the two when using RocksDB, I think it's better to be safe than sorry [1] and assume the worst, i.e. assume that RocksDB is actually comes just under GPLv2. Even if we decide to distribute the RocksDB as a part of Kudu (librocksdb) under Apache 2.0, I don't have enough expertise if licensing and patent issues to add my binding +2 for having Apache Kudu coming with librocksdb linked into kudu-master and kudu-tserver binaries because I don't understand potential issues that might arise out of such a dual-licensing approach. I think that the safest way is to go down the route similar to what has been done in the scope of https://issues.apache.org/jira/browse/KUDU-2990 (memkind/libnuma) and don't link rocksdb library into Kudu code, but rather use dlopen to open the library instead. Yingchun, what do you think of doing something similar to what's been done w.r.t. using dlopen() instead of direct linkage? You might take a look at https://github.com/apache/kudu/commit/ba908efa15774bb24b5bfa4ea88915161d1100d1 as a reference. Thanks a lot! [1] https://www.apache.org/legal/resolved.html#category-x -- To view, visit http://gerrit.cloudera.org:8080/18569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie72f6914eb5653a9c034766c6cd3741a8340711f Gerrit-Change-Number: 18569 Gerrit-PatchSet: 47 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 23 Aug 2023 19:26:36 +0000 Gerrit-HasComments: Yes
