Hello Marton Greber, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/20414
to review the following change.
Change subject: KUDU-3504 Crash master on subprocess death
......................................................................
KUDU-3504 Crash master on subprocess death
In the past, there were several instances when the Ranger subprocess
crashed. In these cases, the master happily went on, but failed to
authorize requests. Since there's no way to restart the subprocess
without restarting the master anyway, it's better to crash the master as
well to make sure the failure of the subprocess is detected in time and
can be addressed.
As there are multiple concurrent calls to Subprocess::DoWait() now, this
commit also changes some member variables to atomic to make sure it's
thread-safe as TSAN complained about a data race.
Change-Id: Iec516f3d684f152bd29874b60b810c526ee5a184
Reviewed-on: http://gerrit.cloudera.org:8080/20365
Tested-by: Kudu Jenkins
Reviewed-by: Marton Greber <[email protected]>
Reviewed-by: Alexey Serbin <[email protected]>
(cherry picked from commit fd98e9e7331a0e8fc6b091faa2d2744a7787e6d7)
---
M src/kudu/ranger/ranger_client.cc
M src/kudu/subprocess/server.cc
M src/kudu/subprocess/server.h
M src/kudu/subprocess/subprocess_proxy.h
M src/kudu/util/subprocess.cc
M src/kudu/util/subprocess.h
6 files changed, 65 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/20414/1
--
To view, visit http://gerrit.cloudera.org:8080/20414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec516f3d684f152bd29874b60b810c526ee5a184
Gerrit-Change-Number: 20414
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
