Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20327 )
Change subject: KUDU-3495 Initialize the bitmap while decoding insert/upsert ...................................................................... Patch Set 5: Code-Review+1 (5 comments) Overall looks good to me, just a few nits. http://gerrit.cloudera.org:8080/#/c/20327/5/src/kudu/common/row_operations-test.cc File src/kudu/common/row_operations-test.cc: http://gerrit.cloudera.org:8080/#/c/20327/5/src/kudu/common/row_operations-test.cc@1008 PS5, Line 1008: TestSchemasNotMatch nit: what about NonMatchingSchemas or SchemasDoNotMatch ? http://gerrit.cloudera.org:8080/#/c/20327/5/src/kudu/common/row_operations-test.cc@1009 PS5, Line 1009: nit for this and other lines: the indent should be 2 spaces [1] per the C++ code style used in the Apache Kudu project [2] [1] https://google.github.io/styleguide/cppguide.html#Spaces_vs._Tabs [2] https://kudu.apache.org/docs/contributing.html#_c_code_style http://gerrit.cloudera.org:8080/#/c/20327/5/src/kudu/common/row_operations-test.cc@1013 PS5, Line 1013: CHECK_OK Consider switching to ASSERT_OK() here and elsewhere in the code of this test. http://gerrit.cloudera.org:8080/#/c/20327/5/src/kudu/common/row_operations-test.cc@1029 PS5, Line 1029: ASSERT_TRUE(ops.size() == 1) nit: consider changing to ASSERT_EQ(1, ops.size()) http://gerrit.cloudera.org:8080/#/c/20327/5/src/kudu/common/row_operations-test.cc@1032 PS5, Line 1032: ASSERT_TRUE(!BitmapTest(ops[0].isset_bitmap, 2)) nit: ASSERT_FALSE(BitmapTest(ops[0].isset_bitmap, 2)) -- To view, visit http://gerrit.cloudera.org:8080/20327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38a33cb58a085bc83854c5145e904c8ed51092a8 Gerrit-Change-Number: 20327 Gerrit-PatchSet: 5 Gerrit-Owner: Song Jiacheng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Song Jiacheng <[email protected]> Gerrit-Comment-Date: Mon, 28 Aug 2023 19:32:05 +0000 Gerrit-HasComments: Yes
