Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/20502 )
Change subject: [master] fix mistake in status message for SOFT_DELETED tables
......................................................................
[master] fix mistake in status message for SOFT_DELETED tables
This fixes a mistake in generating status messages for tables
transitioning into the SOFT_DELETED state. The issue was pointed at
by the compiler with the following warnings:
src/kudu/master/catalog_manager.cc:6049:52: warning: adding 'bool' to a
string does not append to the string [-Wstring-plus-int]
string deletion_msg = "Table soft deleted at " +
~~~~~~~~~~~~~~~~~~~~~~~~~^
src/kudu/master/catalog_manager.cc:6050:71: warning: operator '?:' has lower
precedence than '+'; '+' will be evaluated first [-Wparentheses]
l.mutable_data()->pb.has_delete_timestamp() ?
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
I also took the liberty of brushing up the corresponding code, comments,
and messages a little bit.
Change-Id: If68032a6750f40698b64a00aea52e3b9ad389d85
Reviewed-on: http://gerrit.cloudera.org:8080/20502
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Yingchun Lai <[email protected]>
---
M src/kudu/master/catalog_manager.cc
1 file changed, 22 insertions(+), 18 deletions(-)
Approvals:
Alexey Serbin: Verified
Yingchun Lai: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20502
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If68032a6750f40698b64a00aea52e3b9ad389d85
Gerrit-Change-Number: 20502
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: KeDeng <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <[email protected]>
