Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20545 )
Change subject: [thirpdarty] upgrade gperftools to 2.13 ...................................................................... Patch Set 1: (2 comments) > (1 comment) > > I'm running a clean third party build on M1 mac, just to double > check. > Other than that one comment, if the build goes through, it looks > good to me! Thanks for the verification. I also made sure it builds and works at my macOS Intel laptop before submitting this patch for review, so it seems we are good w.r.t. macOS build and functionality with this patch. http://gerrit.cloudera.org:8080/#/c/20545/1/thirdparty/download-thirdparty.sh File thirdparty/download-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/20545/1/thirdparty/download-thirdparty.sh@194 PS1, Line 194: GPERFTOOLS_PATCHLEVEL=1 > You delete 1 line and decrease the value with 2? The convention is to have the patch level to be the number of patches applied, unless that's some extra iteration on the same version of the package. When changing version of the package, it's a good time to sync the patch level with the number of actual patches applied. http://gerrit.cloudera.org:8080/#/c/20545/1/thirdparty/patches/gperftools-Replace-namespace-base-with-namespace-tcmalloc.patch File thirdparty/patches/gperftools-Replace-namespace-base-with-namespace-tcmalloc.patch: http://gerrit.cloudera.org:8080/#/c/20545/1/thirdparty/patches/gperftools-Replace-namespace-base-with-namespace-tcmalloc.patch@1 PS1, Line 1: commit 8f04cffe25ca339841ce0ac67c98bb9a74caa9fc > Could you touch upon the changes in this patch file? (is it a rebase, or ma That automatic edit -- the command is in the description. The idea is to avoid conflicts with some code in gperf that's also imported unger gutils. I guess with Atomics removed from gperftools 2.13 (they switched to std::atomic), there are less conflicts, but I decided to go ahead of what's been used so far and use the same approach of renaming base namespce into tcmalloc in gperftools built in Kudu's thirdparty. -- To view, visit http://gerrit.cloudera.org:8080/20545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4916bf64ea90bb148e0abf31779106a57061a15 Gerrit-Change-Number: 20545 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 09 Oct 2023 18:31:11 +0000 Gerrit-HasComments: Yes
