Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20514 )
Change subject: KUDU-3507 Fix mini ranger port detection ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20514/2/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: http://gerrit.cloudera.org:8080/#/c/20514/2/src/kudu/util/test_util.cc@584 PS2, Line 584: // lsof exits with 1 even if there is no data: : // https://github.com/lsof-org/lsof/issues/128 : // (-Q option would solve it, but its only available on new systems : // like ubuntu 23.04) How is this applicable to the case of running the lsof as it's done here? If it's not, I don't think it makes sense to hide the errors because it would make troubleshooting harder if something isn't working with lsof. -- To view, visit http://gerrit.cloudera.org:8080/20514 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89c3409e9efd53a821a6d4244a35564e134323bb Gerrit-Change-Number: 20514 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 11 Oct 2023 19:01:28 +0000 Gerrit-HasComments: Yes
