Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20575 )
Change subject: [thirdparty] bump curl version up to 8.4.0 ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/20575/3/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/20575/3/thirdparty/build-definitions.sh@782 PS3, Line 782: if [ -n "$OPENSSL_PATH" ]; then : CONFIGURE_OPTS+=" --with-openssl=${OPENSSL_PATH}" : else : CONFIGURE_OPTS+=" --with-openssl" : fi Is it possible to keep this uniform? Say, just have --with-openssl and rely on the CFLAGS and LDFLAGS propagated from build-thirdparty.sh, as it used to be in prior versions? -- To view, visit http://gerrit.cloudera.org:8080/20575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ba976899bb23d95bff1c5386f417d36f0b4b504 Gerrit-Change-Number: 20575 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Tue, 17 Oct 2023 03:55:36 +0000 Gerrit-HasComments: Yes
