Hello Yingchun Lai, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20578
to look at the new patch set (#4).
Change subject: [style] clean-up on virtual & override specifiers
......................................................................
[style] clean-up on virtual & override specifiers
Since Kudu switched to C++17 for non-exported code long time ago,
the OVERRIDE macro's usage can be limited to the files comprising
the exported API where C++98 compatibility is still required.
Also, adding 'virtual' specifier is redundant for virtual methods
that override corresponding methods from a base class.
One more theme of this patch is updating the code to use
explicitly-defaulted constructors and destructors, and adding the
'override' specifier for destructors when appropriate. In addition,
many warnings reported by Clang-Tidy were addressed as well.
This patch doesn't contain any functional modifications.
Change-Id: Id04a71fd3f1afe45e5aad8a92030e6f8f344fcf5
---
M src/kudu/benchmarks/tpch/rpc_line_item_dao-test.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
M src/kudu/cfile/binary_dict_block.h
M src/kudu/cfile/binary_plain_block.h
M src/kudu/cfile/binary_prefix_block.h
M src/kudu/cfile/block_encodings.h
M src/kudu/cfile/bshuf_block.h
M src/kudu/cfile/cfile-test-base.h
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/cfile/encoding-test.cc
M src/kudu/cfile/plain_bitmap_block.h
M src/kudu/cfile/plain_block.h
M src/kudu/cfile/rle_block.h
M src/kudu/client/batcher.cc
M src/kudu/client/callbacks.h
M src/kudu/client/client-test.cc
M src/kudu/client/master_rpc.cc
M src/kudu/client/master_rpc.h
M src/kudu/client/stubs.h
M src/kudu/client/write_op.h
M src/kudu/codegen/code_cache.cc
M src/kudu/codegen/row_projector.h
M src/kudu/common/generic_iterators.cc
M src/kudu/common/iterator.h
M src/kudu/consensus/consensus_meta-test.cc
M src/kudu/consensus/consensus_peers-test.cc
M src/kudu/consensus/consensus_peers.h
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/consensus_queue.h
M src/kudu/consensus/log.h
M src/kudu/consensus/log_cache-test.cc
M src/kudu/consensus/log_index-test.cc
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/block_manager.h
M src/kudu/fs/data_dirs-test.cc
M src/kudu/fs/fs-test-util.h
M src/kudu/gutil/port.h
M src/kudu/gutil/ref_counted_memory.h
M src/kudu/gutil/stl_util.h
M src/kudu/gutil/threading/thread_collision_warner.h
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/consistency-itest.cc
M src/kudu/integration-tests/create-table-stress-test.cc
M src/kudu/integration-tests/full_stack-insert-scan-test.cc
M src/kudu/integration-tests/linked_list-test.cc
M src/kudu/integration-tests/location_assignment-itest.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/master_replication-itest.cc
M src/kudu/integration-tests/tablet_history_gc-itest.cc
M src/kudu/integration-tests/ts_authz-itest.cc
M src/kudu/integration-tests/update_scan_delta_compact-test.cc
M src/kudu/master/catalog_manager.h
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.h
M src/kudu/rpc/connection.cc
M src/kudu/rpc/mt-rpc-test.cc
M src/kudu/rpc/periodic-test.cc
M src/kudu/rpc/protoc-gen-krpc.cc
M src/kudu/rpc/retriable_rpc.h
M src/kudu/rpc/rpc.h
M src/kudu/rpc/rpc_service.h
M src/kudu/rpc/rpc_sidecar.h
M src/kudu/rpc/service_if.h
M src/kudu/rpc/service_pool.h
M src/kudu/rpc/transfer.h
M src/kudu/server/generic_service.h
M src/kudu/server/glog_metrics.cc
M src/kudu/server/monitored_task.h
M src/kudu/tablet/cfile_set-test.cc
M src/kudu/tablet/cfile_set.h
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/compaction.h
M src/kudu/tablet/composite-pushdown-test.cc
M src/kudu/tablet/delta_compaction-test.cc
M src/kudu/tablet/delta_store.h
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltamemstore.h
M src/kudu/tablet/diskrowset.h
M src/kudu/tablet/major_delta_compaction-test.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/memrowset.h
M src/kudu/tablet/ops/op.h
M src/kudu/tablet/ops/op_driver.cc
M src/kudu/tablet/rowset.h
M src/kudu/tablet/tablet-test-util.h
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_history_gc-test.cc
M src/kudu/tablet/tablet_metadata-test.cc
M src/kudu/tablet/tablet_mm_ops-test.cc
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tablet/tablet_throttle-test.cc
M src/kudu/tablet/txn_coordinator.h
M src/kudu/tools/create-table-tool-test.cc
M src/kudu/tools/diagnostics_log_parser.h
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote-test.cc
M src/kudu/tools/ksck_remote.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tserver/tablet_copy_service-test.cc
M src/kudu/tserver/tablet_replica_lookup.h
M src/kudu/tserver/tablet_server-stress-test.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tablet_service.h
M src/kudu/tserver/ts_tablet_manager-test.cc
M src/kudu/tserver/ts_tablet_manager.h
M src/kudu/util/async_util-test.cc
M src/kudu/util/bit-stream-utils.inline.h
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
M src/kudu/util/cache_metrics.h
M src/kudu/util/cloud/instance_metadata.h
M src/kudu/util/compression/compression_codec.cc
M src/kudu/util/compression/compression_codec.h
M src/kudu/util/debug/trace_event.h
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/debug/trace_event_impl.h
M src/kudu/util/debug/trace_event_synthetic_delay.cc
M src/kudu/util/env-test.cc
M src/kudu/util/env.h
M src/kudu/util/env_posix.cc
M src/kudu/util/hdr_histogram.h
M src/kudu/util/jsonwriter.cc
M src/kudu/util/jwt.h
M src/kudu/util/logging.cc
M src/kudu/util/memory/memory.h
M src/kudu/util/metrics.cc
M src/kudu/util/metrics.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/pb_util-internal.h
M src/kudu/util/pb_util-test.cc
M src/kudu/util/protoc-gen-insertions.cc
M src/kudu/util/rolling_log-test.cc
M src/kudu/util/stack_watchdog-test.cc
M src/kudu/util/test_util.h
M src/kudu/util/threadpool-test.cc
M src/kudu/util/trace-test.cc
M src/kudu/util/web_callback_registry.h
146 files changed, 962 insertions(+), 985 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/20578/4
--
To view, visit http://gerrit.cloudera.org:8080/20578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id04a71fd3f1afe45e5aad8a92030e6f8f344fcf5
Gerrit-Change-Number: 20578
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <ale...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com>
Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org>
