Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 )
Change subject: KUDU-3483 Fix flushing data in batch when table schema changed ...................................................................... Patch Set 21: Code-Review+2 (1 comment) This patch looks good to me! Feel free to revv it if adding the coverage for MANUAL_FLUSH right in this patch, but having that in a separate future patch is totally fine. Thank you for the fix! http://gerrit.cloudera.org:8080/#/c/19949/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java: http://gerrit.cloudera.org:8080/#/c/19949/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java@154 PS20, Line 154: ll, 1); > Yes. Do you plan to add that in a separate patch or you'd rather do that as part of this one? Either way is OK with me. Thank you! -- To view, visit http://gerrit.cloudera.org:8080/19949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6501962b32814d121f180b2942999c402d927db Gerrit-Change-Number: 19949 Gerrit-PatchSet: 21 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 23 Oct 2023 17:03:56 +0000 Gerrit-HasComments: Yes
