Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20613 )
Change subject: Fix a unit test in aarch64 system ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20613/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20613/2//COMMIT_MSG@9 PS2, Line 9: The block size is x86 architecture is 4K, but in aarch64 is : 64K. Isn't it just a parameter of the underlying filesystem (I guess you refer to IO block size, right)? If so, maybe it makes sense using Env::GetBlockSize() call to determine the optimal IO block size, similar to what's done in the TestContainerWithManyHoles scenario? -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 24 Oct 2023 06:26:36 +0000 Gerrit-HasComments: Yes
