Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/20619 )
Change subject: [tablet] fix compilation warnings
......................................................................
[tablet] fix compilation warnings
This patch fixes the following compilation warnings on macOS:
-----
src/kudu/tablet/compaction-test.cc:281:53: warning: format specifies type
'long' but the argument has type 'int64_t' (aka 'long long') [-Wformat]
snprintf(keybuf, sizeof(keybuf), kRowKeyFormat, row_key);
-----
src/kudu/tablet/ops/op_driver.cc:82:16: warning: 'OpCompleted' overrides a
member function but is not marked 'override' [-Winconsistent-missing-override]
virtual void OpCompleted() {
^
src/kudu/tablet/ops/op.h:338:16: note: overridden virtual function is here
virtual void OpCompleted();
^
Change-Id: I481c5bb3e83575c3bfe24a31ff077bd528f17e48
Reviewed-on: http://gerrit.cloudera.org:8080/20619
Tested-by: Kudu Jenkins
Reviewed-by: Yifan Zhang <[email protected]>
Reviewed-by: Mahesh Reddy <[email protected]>
---
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/ops/op_driver.cc
2 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yifan Zhang: Looks good to me, approved
Mahesh Reddy: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/20619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I481c5bb3e83575c3bfe24a31ff077bd528f17e48
Gerrit-Change-Number: 20619
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
