Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20546 )
Change subject: [compaction] Skip memory allocation for ancient undo deltas ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/20546/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20546/4//COMMIT_MSG@10 PS4, Line 10: we it http://gerrit.cloudera.org:8080/#/c/20546/4//COMMIT_MSG@11 PS4, Line 11: ancient Please give more detail about the definition `ancient`? http://gerrit.cloudera.org:8080/#/c/20546/4/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: http://gerrit.cloudera.org:8080/#/c/20546/4/src/kudu/tablet/compaction.cc@1243 PS4, Line 1243: in the calle Can you describe the caller more clear? http://gerrit.cloudera.org:8080/#/c/20546/4/src/kudu/tablet/compaction.cc@1307 PS4, Line 1307: // in caller while processing ancient undo deltas. Essentially, Maybe you can remove this comments to line 1282. Here no code change, it looks like a little strange. -- To view, visit http://gerrit.cloudera.org:8080/20546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb41636a3ac063478fe181560d4ec85dadeb0ef3 Gerrit-Change-Number: 20546 Gerrit-PatchSet: 4 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Fri, 27 Oct 2023 03:02:39 +0000 Gerrit-HasComments: Yes
