Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 )
Change subject: KUDU-3498 Scanner keeps alive in periodically ...................................................................... Patch Set 20: (4 comments) http://gerrit.cloudera.org:8080/#/c/20282/18/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/20282/18/src/kudu/client/client.h@2958 PS18, Line 2958: This can be called after the scanner is opened > What if this method called multiple times? Does it behave as expected? I will check whether the timer started or not. http://gerrit.cloudera.org:8080/#/c/20282/18/src/kudu/client/client.h@2963 PS18, Line 2963: is not > messenger Done http://gerrit.cloudera.org:8080/#/c/20282/18/src/kudu/client/client.h@2974 PS18, Line 2974: > Could this and the corresponding KeepAlivePeriodically() method be named to Done http://gerrit.cloudera.org:8080/#/c/20282/18/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: http://gerrit.cloudera.org:8080/#/c/20282/18/src/kudu/client/scanner-internal.cc@107 PS18, Line 107: return Status::OK(); : } > Why to instantiate a separate messenger just to send keep-alive requests fo Done. I will reuse the messenger in client. -- To view, visit http://gerrit.cloudera.org:8080/20282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1165d96814eb4bcd5db9b5cb60403fffc5b18c81 Gerrit-Change-Number: 20282 Gerrit-PatchSet: 20 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Wed, 01 Nov 2023 10:12:31 +0000 Gerrit-HasComments: Yes
