Alexey Serbin has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/20642 )

Change subject: [util] check if EVP_CIPHER_CTX_new() returns null
......................................................................

[util] check if EVP_CIPHER_CTX_new() returns null

Per documentation [1], EVP_CIPHER_CTX_new() can return nullptr in case
of a failure.  This patch updates the code to handle such a condition.

I also updated the code to use the traits and ssl_make_unique() for
brevity and uniformity across src/kudu/util and src/kudu/security.

[1] https://www.openssl.org/docs/man1.1.1/man3/EVP_CIPHER_CTX_new.html

Change-Id: Ia41c543325ed1407b5afce5d391a14e4ea0276d1
Reviewed-on: http://gerrit.cloudera.org:8080/20642
Tested-by: Kudu Jenkins
Reviewed-by: Mahesh Reddy <[email protected]>
Reviewed-by: Attila Bukor <[email protected]>
---
M src/kudu/util/env_posix.cc
1 file changed, 24 insertions(+), 9 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Mahesh Reddy: Looks good to me, but someone else must approve
  Attila Bukor: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/20642
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia41c543325ed1407b5afce5d391a14e4ea0276d1
Gerrit-Change-Number: 20642
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>

Reply via email to