Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20655 )
Change subject: Minor refactoring on kudu-tool-test (take 2) ...................................................................... Minor refactoring on kudu-tool-test (take 2) Move the parameterize logic of kudu-tool-test from kudu-tool-test.cc to tool_test_util.cc, the latter one is more general because the RunKuduTool() in tool_test_util.cc is a more general utility which is called in mutiple test files. Change-Id: I86d2120aa689473495ec8d4604caee1123060663 Reviewed-on: http://gerrit.cloudera.org:8080/20655 Tested-by: Kudu Jenkins Reviewed-by: Yifan Zhang <[email protected]> --- M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_test_util.cc 2 files changed, 17 insertions(+), 12 deletions(-) Approvals: Kudu Jenkins: Verified Yifan Zhang: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20655 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I86d2120aa689473495ec8d4604caee1123060663 Gerrit-Change-Number: 20655 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]>
