Ashwani Raina has posted comments on this change. (
http://gerrit.cloudera.org:8080/20690 )
Change subject: [cfile] clean up on IndexBlock{Builder,Iterator,Reader}
......................................................................
Patch Set 6:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/20690/6/src/kudu/cfile/index_block.cc
File src/kudu/cfile/index_block.cc:
http://gerrit.cloudera.org:8080/#/c/20690/6/src/kudu/cfile/index_block.cc@149
PS6, Line 149: max_size
What does max_size mean here? Does it represent the limit for sanity check only
or is it actual size of trailer data?
http://gerrit.cloudera.org:8080/#/c/20690/6/src/kudu/cfile/index_block.cc@152
PS6, Line 152: fieds
fields
http://gerrit.cloudera.org:8080/#/c/20690/6/src/kudu/cfile/index_block.cc@153
PS6, Line 153: // IndexBlockTrailerPB message, it contains at least two
required fields now:
: // * int32_t num_entries: at least one byte serialized with
varint encoding
: // * BlockType type: enum, at least one byte serialized
: // So, the total for the minimum length is 5 bytes: (1 + 1) +
(1 + 1).
Is it possible to add some details as comments to represent an example in some
visual format?
--
To view, visit http://gerrit.cloudera.org:8080/20690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If83dd132b577a481a2ddaa09e2657639f8b92c7d
Gerrit-Change-Number: 20690
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 10 Nov 2023 13:07:56 +0000
Gerrit-HasComments: Yes
