Abhishek Chennaka has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/20702 )
Change subject: [tablet] modernize MultiColumnWriter's code
......................................................................
[tablet] modernize MultiColumnWriter's code
This patch contain a few micro-optimizations, but it doesn't contain
any functional changes:
* std::unique_ptr replaced raw pointers in the cfile_writers_ array,
so no need to use the STLDeleteElements macro
* replaced CHECK() with DCHECK() where appropriate
* added more DCHECK() macros to enforce logical consistency
* removed virtual base from the class and made it final
* added tablet identifier into status objects and error messages
to make it possible to attribute errors to particular tablets
Change-Id: Ife716bf62338ca896072ce7fce3aea9d5f5204ca
Reviewed-on: http://gerrit.cloudera.org:8080/20702
Tested-by: Alexey Serbin <[email protected]>
Tested-by: Kudu Jenkins
Reviewed-by: Abhishek Chennaka <[email protected]>
---
M src/kudu/tablet/multi_column_writer.cc
M src/kudu/tablet/multi_column_writer.h
2 files changed, 62 insertions(+), 62 deletions(-)
Approvals:
Alexey Serbin: Verified
Kudu Jenkins: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife716bf62338ca896072ce7fce3aea9d5f5204ca
Gerrit-Change-Number: 20702
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
