Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20310 )
Change subject: KUDU-3497 optimize leader rebalancer algorithm ...................................................................... Patch Set 17: (1 comment) > Patch Set 17: Code-Review+2 > > (1 comment) Thank you for the review! http://gerrit.cloudera.org:8080/#/c/20310/10/src/kudu/master/auto_leader_rebalancer.cc File src/kudu/master/auto_leader_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/20310/10/src/kudu/master/auto_leader_rebalancer.cc@248 PS10, Line 248: string leader_uuid = from_info.first; : int32_t need_transfer_count = from_info.second; : int32_t pick_count = 0; : vector<string>& uuid_leaders = leader_tablet_ids_by_ts_uuid[leader_uuid]; : std::shuffle(uuid_leaders.begin(), uuid_leaders.end(), random_generator_); : // This loop would generate 'uuid_leaders.size()' leader transferring tasks at most. : // Every task would p > Thank you for the explanation. My comment originated from the perception ' I think, no, 'remaining_tablets' can not turn negative. The formula of 'remaining_tablets' is actually: 'remaining_tablets' = 'remaining_tablets' - leadercount + (1 or 0); And the "target_leader_count" is computed by the code below: const uint32_t target_leader_count = (remaining_tablets + remaining_tservers - 1) / remaining_tservers; So "target_leader_count" is never more than "remaining_tablets", and 'remaining_tablets' never be less than 0. -- To view, visit http://gerrit.cloudera.org:8080/20310 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f1fe796fd98da2d8764da793b7e254319e6348a Gerrit-Change-Number: 20310 Gerrit-PatchSet: 17 Gerrit-Owner: Song Jiacheng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Song Jiacheng <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 21 Nov 2023 03:37:20 +0000 Gerrit-HasComments: Yes
