Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20741 )
Change subject: [tools] disambiguate parse_metrics' output ...................................................................... [tools] disambiguate parse_metrics' output This patch improves the output of the 'kudu diagnostic parse_metrics' CLI tool. Prior to this patch, it was impossible to tell between absent metric values at a particular timestamp and zeros. With this patch, an absent value and undefined rate of change of a metric for a particular timestamp are indicated with the '?' ASCII character. Change-Id: Iba0bc90a6313bd9096fa1493dd902254cdda1dc1 Reviewed-on: http://gerrit.cloudera.org:8080/20741 Tested-by: Kudu Jenkins Reviewed-by: Abhishek Chennaka <[email protected]> --- M src/kudu/tools/diagnostics_log_parser.cc M src/kudu/tools/diagnostics_log_parser.h M src/kudu/tools/kudu-tool-test.cc 3 files changed, 80 insertions(+), 46 deletions(-) Approvals: Kudu Jenkins: Verified Abhishek Chennaka: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20741 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iba0bc90a6313bd9096fa1493dd902254cdda1dc1 Gerrit-Change-Number: 20741 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
