Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20748 )
Change subject: [rpc] micro-optimizations on RpczStore::LogTrace ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20748/1/src/kudu/rpc/rpcz_store.cc File src/kudu/rpc/rpcz_store.cc: http://gerrit.cloudera.org:8080/#/c/20748/1/src/kudu/rpc/rpcz_store.cc@a269 PS1, Line 269: > It might be helpful if someone(like me) is used to search for this string d Indeed, some users may use it as the keyword to search traces in mass logs, it would be better to keep the behavior. -- To view, visit http://gerrit.cloudera.org:8080/20748 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b9cd537ad9797773f6934ae72d0e865db9770a1 Gerrit-Change-Number: 20748 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 08 Dec 2023 08:51:44 +0000 Gerrit-HasComments: Yes
