Alexey Serbin has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/20781 )

Change subject: KUDU-3532: Fix range aware replica placement bug
......................................................................

KUDU-3532: Fix range aware replica placement bug

An implicit conversion from unsigned long to int caused
an std::length_error to be thrown when a vector tried to
reserve a a size greater than the max size. This happens
when a negative number is converted. This bug was
introduced by changelist [1].

I also added tests with tablet servers in multiple
locations. This omission caused this bug to go
unnoticed until now.

[1] https://github.com/apache/kudu/commit/10fdaf6a9

Change-Id: Id5d696d58965590a9f91f8b1b59f23225bbad8ee
Reviewed-on: http://gerrit.cloudera.org:8080/20781
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <[email protected]>
---
M src/kudu/master/placement_policy-test.cc
M src/kudu/master/placement_policy.cc
2 files changed, 174 insertions(+), 60 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/20781
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5d696d58965590a9f91f8b1b59f23225bbad8ee
Gerrit-Change-Number: 20781
Gerrit-PatchSet: 2
Gerrit-Owner: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)

Reply via email to