Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20788 )
Change subject: KUDU-3532: Fix range aware replica placement bug ...................................................................... KUDU-3532: Fix range aware replica placement bug An implicit conversion from unsigned long to int caused an std::length_error to be thrown when a vector tried to reserve a a size greater than the max size. This happens when a negative number is converted. This bug was introduced by changelist [1]. I also added tests with tablet servers in multiple locations. This omission caused this bug to go unnoticed until now. [1] https://github.com/apache/kudu/commit/10fdaf6a9 Change-Id: Id5d696d58965590a9f91f8b1b59f23225bbad8ee Reviewed-on: http://gerrit.cloudera.org:8080/20781 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <[email protected]> (cherry picked from commit a84c8376a78b3a86be75d434e0f7ff2853c0c880) Reviewed-on: http://gerrit.cloudera.org:8080/20788 Reviewed-by: Abhishek Chennaka <[email protected]> Tested-by: Alexey Serbin <[email protected]> --- M src/kudu/master/placement_policy-test.cc M src/kudu/master/placement_policy.cc 2 files changed, 174 insertions(+), 60 deletions(-) Approvals: Abhishek Chennaka: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/20788 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: merged Gerrit-Change-Id: Id5d696d58965590a9f91f8b1b59f23225bbad8ee Gerrit-Change-Number: 20788 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]>
