Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20764 )
Change subject: [compaction] Fix the incorrect memory budgeting condition ...................................................................... [compaction] Fix the incorrect memory budgeting condition Compaction budgeting code has minimum size of on-disk deltas that is used to decide whether memory budgeting can be applied or not. While comparing the actual on-disk size of deltas with minimum value the fact that minimum value is in MBytes is not taken into account and is directly compared with on-disk size which is in bytes. The fix is to convert the min size in MBs to bytes first and then compare. Change-Id: I8928b15750f100785c510ee8086e5a6281b3a7b8 Reviewed-on: http://gerrit.cloudera.org:8080/20758 Tested-by: Kudu Jenkins Reviewed-by: Mahesh Reddy <[email protected]> Reviewed-by: Ádám Bakai <[email protected]> Reviewed-by: Wang Xixu <[email protected]> Reviewed-by: Yingchun Lai <[email protected]> (cherry picked from commit ae7b08c006167da1ebb0c4302e5d6d7aa739a862) Reviewed-on: http://gerrit.cloudera.org:8080/20764 Reviewed-by: Abhishek Chennaka <[email protected]> --- M src/kudu/tablet/compaction_policy.cc 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Kudu Jenkins: Verified Mahesh Reddy: Looks good to me, but someone else must approve Abhishek Chennaka: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20764 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: merged Gerrit-Change-Id: I8928b15750f100785c510ee8086e5a6281b3a7b8 Gerrit-Change-Number: 20764 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]>
